prometheus-node-exporter-lua: Added TLS support for the custom uhttpd server #25560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By signed I meant having the signed-off-by tag in the commit description ;) |
|
OK, missing signature for signed-off-by added. Sorry for forgetting about it |
|
Make sure to fix 'test formalities' |
…he custom port selected to provide prometheus node exporter. The changes have been performed by enhancing the already existing modes of operation for the uhttpd server. By merging this commit, the /etc/config/prometheus-node-exporter-lua file receives another two options, which allow the configuration of independent keys and certificate for the uhttpd server. Signed-off-by: Thomas Rahimi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me @thomasrahimi
Compile tested: No changes to binary code - Thus not tested yet
Run tested: ipq40xx, FritzBox 7520, 23.05.5, tested on my working router and worked as expected in both cases (http and https)
Description:
Added TLS support for the uhttpd server, which is spun up when starting prometheus-node-exporter-lua. The whole support has been implemented as an additional option, which allows to maintain prometheus-node-exporter-lua with the current mode of operation, which is the unencrypted http server.
The conditions to evaluate, whether the required certificate and key are present have been crafted in accordance with suggestions made by project maintainers. Thus all possible cases when dealing with the options and the paths for the certificates should be handled by the shell code to start prometheus-node-exporter-lua.