Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.10] python-requests (and deps): add hostbuild #25542

Open
wants to merge 5 commits into
base: openwrt-24.10
Choose a base branch
from

Conversation

vidplace7
Copy link
Contributor

Maintainer: @commodo @BKPepe
Compile tested: OpenWRT One 24.10 branch

Description:
Add hostbuild directives for python-requests and it's dependencies.

Backport to 24.10

Cherry-picked PRs:

@BKPepe
Copy link
Member

BKPepe commented Dec 12, 2024

I will gladly accept this, when we first have it all working in the master branch.

@vidplace7
Copy link
Contributor Author

I will gladly accept this, when we first have it all working in the master branch.

Everything related to requests has been merged into master, is there something else that needs to be done?
Or would you like for me to wait for all of my PRs to get merged into master first?

@BKPepe
Copy link
Member

BKPepe commented Dec 14, 2024

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

@vidplace7 vidplace7 force-pushed the backport24-python-requests_host branch from 6df94eb to c5d5f28 Compare December 14, 2024 15:43
@ynezz
Copy link
Member

ynezz commented Dec 16, 2024

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

FYI you can see it already here https://github.com/openwrt-meshtastic/openwrt-meshtastic/actions/runs/12342391075, the packages are available in https://github.com/openwrt-meshtastic/repo/tree/gh-pages/main

@vidplace7
Copy link
Contributor Author

No, no. You are adding packages to the master branch to have a working PlatformIO, which has not been added so far. Once it is verified to be working in the master branch to see the why the host packages were added, then it could be backported. Nonetheless, for now, backporting hostbuilds for OpenWrt 24.10 does not make any sense.

FYI you can see it already here https://github.com/openwrt-meshtastic/openwrt-meshtastic/actions/runs/12342391075, the packages are available in https://github.com/openwrt-meshtastic/repo/tree/gh-pages/main

Hey @ynezz :) I'm glad you found my "repo".
The ultimate goal is outlined at https://github.com/openwrt-meshtastic/openwrt-meshtastic/blob/main/upstreaming.md

As you saw, I am doing my best to test each package thoroughly and for as many archs as I can. I really appreciate all of the OpenWRT team's critical feedback so I can make these contributions meaningful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants