adguardhome: Bump to 0.107.54 #25521
Conversation
Bump version to 0.107.54, change log in links below. Use source from upstream tag tarballs instead of Git repo. Move working directory from `/var/adguardhome` to `/var/lib/adguardhome`, according to Linux FHS. Add option to store PID file, defaulting to `/run/adguardhome.pid`. Link: https://github.com/AdguardTeam/AdGuardHome/milestone/89?closed=1 Signed-off-by: Ryan Keane <[email protected]>
Originally posted by @BKPepe in #25450 (comment) |
| PKG_SOURCE_VERSION:=v$(PKG_VERSION) | ||
| PKG_SOURCE_URL:=https://github.com/AdguardTeam/AdGuardHome | ||
| PKG_MIRROR_HASH:=d74702bc4f8b82bda64a0a937a98e73ee602c21b9361c0c683671212e03e9316 | ||
| PKG_SOURCE:=v$(PKG_VERSION).tar.gz |
There was a problem hiding this comment.
No, please check how other packages have done for this.
There was a problem hiding this comment.
It feels so nasty when we have a tarball for this but you just cant use it because of download.pl
And it's even worse when the git script is doing a full clone from the repository, it's almost 3x larger than the tarball from tags
There was a problem hiding this comment.
Does the size matter on the computer, which you are using for the buildsystem to evenutally to cross-compile packages for your devices? :-) I did not verify the size so far of your proposed solution, which says use upstream tag tarballs without the reason, why instead of the Git repo.
However, using Git sources is not preferred at least from my point of view. Its a big security risk, because if someone tinkers with the tarball, checksum is not verified anyhow. See: https://lists.openwrt.org/pipermail/openwrt-devel/2024-April/042521.html
In your case, you might want to use codeload, though. If we are talking about using codeload or your proposed solution, dont forget, that the tarball is created by GitHub itself, which means that there isnt checksum to verify (see checksums.txt file) in their release. Sometimes autogenerated tarballs are missing some things, which are required to have to build the package and the tarball from GitHub can be changed anyhow and then the checksum is not valid (I havent experienced this case, yet, but others said yes...)
So, I dont find anything wrong to keep using Git sources, i still dont know the reason, why you did it. 🤷
We are not living in the ideal world.
There was a problem hiding this comment.
Please do not repeat the same mistakes with libxz issue
And it's even worse when the git script is doing a full clone from the repository, it's almost 3x larger than the tarball from tags
also, why is the git script not doing shallow clones? does it pull the entire commit history?
Bump version to 0.107.54, change log in links below.
Use source from upstream tag tarballs instead of Git repo. Move working directory from
/var/adguardhometo/var/lib/adguardhome, according to Linux FHS.Add option to store PID file, defaulting to
/run/adguardhome.pid.Link: https://github.com/AdguardTeam/AdGuardHome/milestone/89?closed=1
Maintainer: @dobo90 @1715173329
Compile tested: working on it
Run tested: not yet
Description: