Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-snmp: add uci section to include additional conf files #25478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rthakur33
Copy link
Contributor

net-snmp allows including additional conf files by specifying then with the includeFile token in the snmpd.conf, this commits adds a uci section that translates to includeFile in snmpd.conf files and hence allows including additional conf files.

the syntax introduced is as follows:

config include 'custom-file'
option path '/tmp/mysnmpd.conf'

@feckert
Copy link
Member

feckert commented Dec 2, 2024

  • Please check your git config the Test-Formalities CI/CD is failing. I think you have not used the same name for Signed-of-by and the name in your git config for the commit.
  • Also please bump the PKG_RELEASE number by one

net-snmp allows including additional conf files by specifying then
with the includeFile token in the snmpd.conf, this commits adds a
uci section that translates to includeFile in snmpd.conf files and
hence allows including additional conf files.

the syntax introduced is as follows:

config include 'custom-file'
    option path '/tmp/mysnmpd.conf'

Signed-off-by: Rahul Thakur <[email protected]>
@rthakur33
Copy link
Contributor Author

  • Please check your git config the Test-Formalities CI/CD is failing. I think you have not used the same Name for Signed-of-by` and the name in your git config for the commit.
  • Also please bump the PKG_RELEASE number by one

both done, thanks

@feckert
Copy link
Member

feckert commented Dec 3, 2024

@stintel any objection?

@rthakur33
Copy link
Contributor Author

@stintel any objection?

@stintel , gentle ping, can you please take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants