strongswan: swanctl: make overtime and send_cert vars local #25474
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When support for send_cert was added in 4b9453b, the $send_cert variable was inadvertently global. Make it local to avoid polluting the global namespace and make the code easier to reason about. Fixes: 4b9453b ("strongswan: Add support for send_cert option") Signed-off-by: Kevin Locke <[email protected]>
$overtime has been used since swanctl.init was added in f9d91f1. However, there's no need for it to be global. Make it local like the other config variables to avoid polluting the global namespace and make the code easier to reason about. Fixes: f9d91f1 ("strongswan: migrate to swanctl configs") Signed-off-by: Kevin Locke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @pprindeville @Thermi
Compile tested: None. Script only change.
Run tested: aarch64, Linksys E8450 mediatek/mt7622, OpenWrt 23.05.5, checked generated
swanctl.confand operationDescription:
Both
$overtimeand$send_certare only used inconfig_remote()inswanctl.init. However, unlike the other local option variables, they are not declared local. This PR does so for consistency, to avoid global namespace pollution, and make the code easier to reason about.For reference,
$overtimewas added in f9d91f1,$send_certin 4b9453b.Thanks for considering,
Kevin