ddns-scripts: refactoring phase 1 scripting #25469
Conversation
|
That apk check should be disabled or fixed @aparcar |
|
Can you please write a comment/context for each change so we have a history in the feature why we did that. |
feckert
changed the title
systemcrash
force-pushed
the
ddns_refactor_phase_1
branch
from
1b20c12 to
42b3aae
Compare
See individual commits and subjects. Or did you want something here in the PR?
Fixed. Thanks. |
systemcrash
force-pushed
the
ddns_refactor_phase_1
branch
from
42b3aae to
efc201c
Compare
|
ping for review. These automated tests are still failing and it's nothing to do with this PR. Closing and reopening to get new tests... |
Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Now a single xargs calls instead of grepping ps output (unreliable). Signed-off-by: Paul Donald <[email protected]>
Same functionality - code reads less 'shouty' and 'stabby'. Signed-off-by: Paul Donald <[email protected]>
Removed redundant if else condition. updater is launched with the same verbosity value anyway. Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Same functionality - code reads less 'shouty' and 'stabby'. Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
Signed-off-by: Paul Donald <[email protected]>
aparcar
force-pushed
the
ddns_refactor_phase_1
branch
from
efc201c to
aa41159
Compare
|
Hi, I just rebased your PR because the failing APK switch was dropped. Please feel free to merge at your convenience (if approved by the maintainer) |
|
Ah, I see now. So all I had to do was rebase on a newer master? |
Yes. |
|
ping.....? |
Maintainer: @chris5560 (?)
Phase 1 of a refactor of the DDNS scripts. Goal: scripts no longer open many sub-shells or call a number of external utilities like
sedandgrepor similar piped chains where the equivalent is available in pure script functionality. (Theurl_updatechecks found within this change-set avoid spawning six potential sub-shells at every run.)Refactors make code less shouty and 'stabby'.
I've tested these changes on my system (23.05.5) for a while now and they show an improvement. Otherwise, the refactor achieves synonymous functionality.
This change-set introduces the ability to stop individual sections (previously missing).