Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update constructor judgments of LLRT #1472

Merged

Conversation

nabetti1720
Copy link
Contributor

In LLRT, this corresponds to the following message that occurs in the execution of the constructor of an object that requires one or more arguments.

See also. unjs/runtime-compat#126

      {
        "name": "api.Request.Request",
        "info": {
          "code": "bcd.testConstructor('Request')",
          "exposure": "Window"
        },
        "result": null,
        "message": "threw TypeError: Error calling function with 0 argument(s) while 1 where expected"
      },

Execution results in LLRT (cli mode):

% ./llrt -v                              
LLRT (darwin arm64) 0.1.14-beta

% ./llrt -e "const req = new Request();"                     
TypeError: Error calling function with 0 argument(s) while 1 where expected
    at <eval> (eval_script:1:13)

@nabetti1720
Copy link
Contributor Author

Hi @queengooborg . Is the signed Commit working?

@nabetti1720 nabetti1720 force-pushed the feat/update-constructor-judgments-of-llrt branch 5 times, most recently from f9b2382 to 1a4ece3 Compare May 24, 2024 11:58
@nabetti1720 nabetti1720 force-pushed the feat/update-constructor-judgments-of-llrt branch from 1a4ece3 to 5266514 Compare May 28, 2024 02:32
@Elchi3
Copy link
Member

Elchi3 commented May 28, 2024

Hey @nabetti1720, looks like it didn't work unfortunately.

If it is verified you would see "verified" with the commit. See for example https://github.com/openwebdocs/mdn-bcd-collector/pull/1487/commits.

@nabetti1720
Copy link
Contributor Author

Hey @nabetti1720, looks like it didn't work unfortunately.

If it is verified you would see "verified" with the commit. See for example https://github.com/openwebdocs/mdn-bcd-collector/pull/1487/commits.

Thanks for the confirmation.
I did confirm that it was indeed Verified✅ on the first commit. However, when I rebase from the GitHub website, it seems to have been removed at some point...

@Elchi3
Copy link
Member

Elchi3 commented May 28, 2024

Ah interesting, I see this is being talked about in the docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-rebase-and-merge. GitHub recommends to "rebase and merge locally, and then push the changes to the pull request's base branch."

@nabetti1720 nabetti1720 force-pushed the feat/update-constructor-judgments-of-llrt branch from 5266514 to 56ca5f5 Compare May 28, 2024 08:39
@nabetti1720
Copy link
Contributor Author

nabetti1720 commented May 28, 2024

Ah interesting, I see this is being talked about in the docs: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#signature-verification-for-rebase-and-merge. GitHub recommends to "rebase and merge locally, and then push the changes to the pull request's base branch."

Hi @Elchi3 , Thanks for the information.

I have force pushed the local content again.
Now you can see that my commit has a Verified icon on it.
image

Do I need to rebase from this state? If you can confirm that my commit is verified, can you rebase and merge it on the maintainer's side?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nabetti1720, this looks good to me. 👍
Congratulations on your first merged pull request in this project! 🎉

@Elchi3 Elchi3 merged commit a9a09a6 into openwebdocs:main May 28, 2024
4 checks passed
@nabetti1720 nabetti1720 deleted the feat/update-constructor-judgments-of-llrt branch May 28, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants