Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add torchvision.MaskRCNN #3504

Merged
merged 14 commits into from
Jun 6, 2024
Merged

Add torchvision.MaskRCNN #3504

merged 14 commits into from
Jun 6, 2024

Conversation

eugene123tw
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD DOC Improvements or additions to documentation OTX 2.0 For OTX v2.0 labels May 15, 2024
@eugene123tw eugene123tw changed the base branch from develop to releases/2.0.0 May 15, 2024 16:07
@github-actions github-actions bot removed DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD DOC Improvements or additions to documentation labels May 15, 2024
@harimkang
Copy link
Contributor

Is this PR a releases/2.0.0 target? Or is it a develop target?

@sovrasov
Copy link
Contributor

I think it's for develop

@sovrasov sovrasov added this to the 2.1.0 milestone May 16, 2024
@eugene123tw eugene123tw changed the base branch from releases/2.0.0 to develop May 20, 2024 07:40
@eugene123tw eugene123tw changed the title [Draft] torchvision maskrcnn Add torchvision.MaskRCNN Jun 3, 2024
@eugene123tw eugene123tw marked this pull request as ready for review June 3, 2024 09:20
@github-actions github-actions bot added the TEST Any changes in tests label Jun 3, 2024
eunwoosh
eunwoosh reviewed Jun 4, 2024
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I left some comments. Please take a look.

src/otx/recipe/instance_segmentation/maskrcnn_efficientnetb2b.yaml Show resolved Hide resolved
src/otx/algo/instance_segmentation/maskrcnn_tv.py Show resolved Hide resolved
@eugene123tw eugene123tw requested a review from eunwoosh June 4, 2024 08:31
@eugene123tw eugene123tw requested a review from kprokofi June 5, 2024 14:42
@kprokofi kprokofi merged commit 81c2d9e into openvinotoolkit:develop Jun 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kprokofi kprokofi kprokofi approved these changes

@harimkang harimkang harimkang approved these changes

@eunwoosh eunwoosh eunwoosh approved these changes

@samet-akcay samet-akcay Awaiting requested review from samet-akcay samet-akcay is a code owner

@vinnamkim vinnamkim Awaiting requested review from vinnamkim vinnamkim is a code owner

@jaegukhyun jaegukhyun Awaiting requested review from jaegukhyun jaegukhyun is a code owner

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner

@sovrasov sovrasov Awaiting requested review from sovrasov sovrasov is a code owner

@sungchul2 sungchul2 Awaiting requested review from sungchul2 sungchul2 is a code owner

@GalyaZalesskaya GalyaZalesskaya Awaiting requested review from GalyaZalesskaya GalyaZalesskaya is a code owner

@negvet negvet Awaiting requested review from negvet negvet is a code owner

@goodsong81 goodsong81 Awaiting requested review from goodsong81 goodsong81 is a code owner

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner

@wonjuleee wonjuleee Awaiting requested review from wonjuleee wonjuleee is a code owner

Assignees
No one assigned
Labels
OTX 2.0 For OTX v2.0 TEST Any changes in tests
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eugene123tw @harimkang @sovrasov @kprokofi @eunwoosh