CORE: Use uint64_t for bitmap configs #1047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Sergei-Lebedev
approved these changes
Nov 12, 2024
|
ok to test |
|
@andylin-hao Thanks. Which org do you represent? |
|
@manjugv Hi, I'm currently a PhD student (https://github.com/andylin-hao) researching on GPU communications. Just came across this problem when researching UCC/X out of curiosity. So I'm not really representing any specfic orgs in this case, though my official affiliation is with Tsinghua University. |
|
@andylin-hao Will you be able to sign a CLA? [1] Without that, we cannot accept the change. [1] https://github.com/openucx/ucc?tab=readme-ov-file#contributing |
|
@manjugv Sure, I just did. Could you let me know to whom should I send the signed CLA? |
|
@andylin-hao DM'ed you details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the bitmap-type config
profile_modeuint64_t to align with recent UCX(S) changes.Why ?
UCX(S) now uses uint64_t for bitmap-type (declared via UCS_CONFIG_TYPE_BITMAP) configurations (see openucx/ucx@8a84af8). UCC should align with this change, otherwise setting bitmap-type config may overwrite the next 4-byte memory during config parsing (see openucx/ucx@8a84af8#diff-8dd28fc04f39623f32e719552443482db8a07986754b3ba0ba48387db94d8bbdL446). In the case of UCC, the
profile_fileoption ofucc_global_optswill be overwritten whenprofile_modeis set.