Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maxweight to helipad preset #1234

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented May 25, 2024

the maxweight of a helipad is often stenciled into the ground in huge block letters, so it's easy to map from aerial imagery.

The preset would benefit from having the maxweight field.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@1ec5
Copy link
Contributor

1ec5 commented May 25, 2024

When we get around to implementing a measurement field type for ideditor/schema-builder#15, one wrinkle will be that helipads in the United States are rated in (thousands of) pounds rather than short tons, and this is what’s visible in aerial imagery. iD will need to add lbs as a third unit option alongside st and kg. We should do this for mass measurements anyways, since weight limits on roads in some U.S. states are posted exclusively in pounds.

Copy link
Collaborator

@tordans tordans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testcase:

Right now this shows as a dropdown field. Is that the best option we have ATM? Do we want to keep the dropdown options?

image

@k-yle
Copy link
Contributor Author

k-yle commented May 25, 2024

Right now this shows as a dropdown field. Is that the best option we have ATM? Do we want to keep the dropdown options?

I'll let someone else answer this, it's been like that for a long time. Not sure if anyone finds the suggestions useful...

@tordans
Copy link
Collaborator

tordans commented May 26, 2024

Right now this shows as a dropdown field. Is that the best option we have ATM? Do we want to keep the dropdown options?

I'll let someone else answer this, it's been like that for a long time. Not sure if anyone finds the suggestions useful...

Yes, makes sense to keep it like it was. At the very least the suggestions are an indicator on how to format the values. And once ideditor/schema-builder#15 lands this will be improved anyway.

@tordans tordans merged commit f2fbc79 into openstreetmap:main Jun 5, 2024
5 checks passed
@tordans
Copy link
Collaborator

tordans commented Jun 5, 2024

Thanks for the addition. I just merged this and added Minh's comment in ideditor/schema-builder#15 (comment) so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants