Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Elevation field to be of type
roadheight
, so that the user can explicitly specify a unit other than meters when appropriate without having to convert the quantity in their head. In the United States, the unit field will default to “ft”, but the user will be able to switch it to “m” if they happen to observe a sign that (unusually) states the elevation in meters. Meanwhile, anywhere else in the world, the editor will behave exactly the same as before: the unit field will show “m” by default, but the resulting tag will omit the unit. Ifele=*
is already tagged, the field shows the currently tagged units, instead of “Unknown” in the case of feet and inches. Since units other than meters are now accepted, the field’s name no longer needs to specify “(Meters)”.This behavior is consistent with the Height Limit field, which also allows feet and inches. Technically, an elevation is not a road height, but elevations happen to be measured in the same units as road heights in both the United States and elsewhere – even in famously messy Puerto Rico, near as I can tell. Once ideditor/schema-builder#15 is implemented,
ele
would map to either thevehicle
orperson-height
usage categories.This change supports a proposal to formally document
ele=*
as yet another key that accepts units, instead of being a prominent outlier. This draft PR helps to demonstrate that the change to documentation would have only minor impact on editors.Fixes openstreetmap/iD#5658.