Fix validation highlighting not working when submit button is pressed bug #3525

Rkareko · 2024-09-30T10:11:35Z

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes
Has a hotfix fix to the Android SDk issue documented here

Engineer Checklist

I have written Unit tests for any new feature(s) and edge cases for bug fixes
I have added any strings visible on UI components to the strings.xml file
I have updated the CHANGELOG.md file for any notable changes to the codebase
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

I have verified Unit tests have been written for any new feature(s) and edge cases
I have verified any strings visible on UI components are in the strings.xml file
I have verifed the CHANGELOG.md file has any notable changes to the codebase
I have verified the solution has been implemented in a configurable and generic way for reuseable components
I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

…licked bug

codecov · 2024-09-30T10:26:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.2%. Comparing base (a5c2fec) to head (aaa0e02).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##              main   #3525   +/-   ##
=======================================
  Coverage     27.2%   27.2%           
- Complexity     752     756    +4     
=======================================
  Files          277     278    +1     
  Lines        14185   14219   +34     
  Branches      2573    2581    +8     
=======================================
+ Hits          3859    3880   +21     
- Misses        9788    9801   +13     
  Partials       538     538

Flag	Coverage Δ
engine	`63.8% <ø> (-0.1%)`	⬇️
geowidget	`15.4% <ø> (ø)`
quest	`5.6% <ø> (+<0.1%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

* Add date service to rules engine facts map (#3519) * Add summary mode (#3500) Co-authored-by: Elly Kitoto <[email protected]> * Refactor PDF config properties in QuestionnaireConfig (#3498) * Refactor to use PdfConfig Initially using QuestionnaireConfig for simplicity. * Process multi QRs in HtmlPopulator * Add new tag to check if Questionnaire has been submitted * Remove subjectType since subjectReference is used * Fix test and spotless * Address review * spotless * Cleanup * spotless * Fix test --------- Co-authored-by: Elly Kitoto <[email protected]> * Fix error validation highlighting not working when submit button is clicked bug (#3525) * Change progress bar color to blue (#3428) * update in-progress color on the map view. (#3529) Signed-off-by: Lentumunai-Mark <[email protected]> * Add medication sort custom search param (#3534) * Add medication sort custom search param * Run spotlessApply * Fix failing time based test * Pld docs adjustment (#3540) * sync typo * correct heading title * update header definition for p2p * upgrade packages * Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected (#3526) * Don't show no results dialogue on map when locations selected on multiselect. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix failing tests. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> * Add Exit Dialog (#3487) * Add exit dialog * Fix a typo * Show Dialog only when Map or Register is visible * PR feedback changes * Fix failing check * Remove incorrect test * Refactor dialog condition logic --------- Co-authored-by: Benjamin Mwalimu <[email protected]> * Refactor working with bitmap images Signed-off-by: Elly Kitoto <[email protected]> * Add the EUSM Burundi flavour and Rename the existing EUSM flavour (#3548) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * Configure submit anyway button (#3535) * Update the Burundi EUSM flavor (#3553) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * - Update the flavor naming - Update the documentation * - Update the flavors section of the documentation to clarify on the naming convention * Bum p up data capture version (#3547) * Map search bug fixes (#3516) * - Updating the infinite scroll paging - Updating the behaviour after clearing search bar on the maps * - spotless apply * - Fix breaking tests on geo widget module * - Fix tests * - Run spotless * - Import `LazyPagingItems` * - Adding tests * - Update the APK naming * Ignore test to be refactored later Signed-off-by: Elly Kitoto <[email protected]> * - Run spotless * Update kujaku version. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix loading related resources Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]>

* Include listRepositoryResourceDataMap to nested list widgets Signed-off-by: Elly Kitoto <[email protected]> * Fix loading related resources data for List widget Signed-off-by: Elly Kitoto <[email protected]> * Refactor loading bitmap images (#3546) * Add date service to rules engine facts map (#3519) * Add summary mode (#3500) Co-authored-by: Elly Kitoto <[email protected]> * Refactor PDF config properties in QuestionnaireConfig (#3498) * Refactor to use PdfConfig Initially using QuestionnaireConfig for simplicity. * Process multi QRs in HtmlPopulator * Add new tag to check if Questionnaire has been submitted * Remove subjectType since subjectReference is used * Fix test and spotless * Address review * spotless * Cleanup * spotless * Fix test --------- Co-authored-by: Elly Kitoto <[email protected]> * Fix error validation highlighting not working when submit button is clicked bug (#3525) * Change progress bar color to blue (#3428) * update in-progress color on the map view. (#3529) Signed-off-by: Lentumunai-Mark <[email protected]> * Add medication sort custom search param (#3534) * Add medication sort custom search param * Run spotlessApply * Fix failing time based test * Pld docs adjustment (#3540) * sync typo * correct heading title * update header definition for p2p * upgrade packages * Update Geowidget to only show the Set Location dialog if no Locations to sync by have been selected (#3526) * Don't show no results dialogue on map when locations selected on multiselect. Signed-off-by: Lentumunai-Mark <[email protected]> * Fix failing tests. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> * Add Exit Dialog (#3487) * Add exit dialog * Fix a typo * Show Dialog only when Map or Register is visible * PR feedback changes * Fix failing check * Remove incorrect test * Refactor dialog condition logic --------- Co-authored-by: Benjamin Mwalimu <[email protected]> * Refactor working with bitmap images Signed-off-by: Elly Kitoto <[email protected]> * Add the EUSM Burundi flavour and Rename the existing EUSM flavour (#3548) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * Configure submit anyway button (#3535) * Update the Burundi EUSM flavor (#3553) * - Add the EUSM Burundi flavour - Rename the exisiting EUSM flavour * - Update the app naming * - update the flavour naming * - Update the flavor naming - Update the documentation * - Update the flavors section of the documentation to clarify on the naming convention * Bum p up data capture version (#3547) * Map search bug fixes (#3516) * - Updating the infinite scroll paging - Updating the behaviour after clearing search bar on the maps * - spotless apply * - Fix breaking tests on geo widget module * - Fix tests * - Run spotless * - Import `LazyPagingItems` * - Adding tests * - Update the APK naming * Ignore test to be refactored later Signed-off-by: Elly Kitoto <[email protected]> * - Run spotless * Update kujaku version. Signed-off-by: Lentumunai-Mark <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix loading related resources Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Lentumunai-Mark <[email protected]> Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> * Fix failing UI tests Signed-off-by: Elly Kitoto <[email protected]> * Interpolate conditionalFhirPathExpressions in listResource (#3538) To pass in evaluated rule variables Signed-off-by: Elly Kitoto <[email protected]> Co-authored-by: Elly Kitoto <[email protected]> * Fix apply stack tint. Signed-off-by: Lentumunai-Mark <[email protected]> * Apply opacity on view properties. (#3564) Signed-off-by: Lentumunai-Mark <[email protected]> * Fix duplication of List view item Signed-off-by: Elly Kitoto <[email protected]> --------- Signed-off-by: Elly Kitoto <[email protected]> Signed-off-by: Lentumunai-Mark <[email protected]> Co-authored-by: Rkareko <[email protected]> Co-authored-by: FikriMilano <[email protected]> Co-authored-by: Lentumunai Mark <[email protected]> Co-authored-by: Peter Lubell-Doughtie <[email protected]> Co-authored-by: Hamza Ahmed Khan <[email protected]> Co-authored-by: Benjamin Mwalimu <[email protected]> Co-authored-by: Lentumunai-Mark <[email protected]> Co-authored-by: L≡ZRS <[email protected]>

Fix error validation highlighting not working when submit button is c…

aaa0e02

…licked bug

Rkareko requested review from ndegwamartin and LZRS September 30, 2024 10:18

LZRS approved these changes Sep 30, 2024

View reviewed changes

Rkareko added this pull request to the merge queue Sep 30, 2024

Merged via the queue into main with commit 404700b Sep 30, 2024
5 checks passed

Rkareko deleted the fix-form-validation-highlighting-on-submit branch September 30, 2024 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix validation highlighting not working when submit button is pressed bug #3525

Fix validation highlighting not working when submit button is pressed bug #3525

Rkareko commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

Fix validation highlighting not working when submit button is pressed bug #3525

Fix validation highlighting not working when submit button is pressed bug #3525

Conversation

Rkareko commented Sep 30, 2024 • edited Loading

codecov bot commented Sep 30, 2024 • edited Loading

Codecov Report

Rkareko commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading