telcov10n: hcp: add tier2 tests and adjust timeout and cron #60827
Conversation
| @@ -9,7 +9,7 @@ echo "************ telco5g cnf-tests commands ************" | |||
|
|
|||
| # Environment Variables required for running the test | |||
| export KUBECONFIG="${SHARED_DIR}"/mgmt-kubeconfig | |||
| NODEPOOL_NAME=$(oc get np -n clusters -o name | cut -d "/" -f 2) | |||
| NODEPOOL_NAME=$(oc get np -n clusters -o name | cut -d "/" -f 2 | sed 's/-secondary$//' | sort | uniq | head -n 1) | |||
There was a problem hiding this comment.
it's better to use jq for such a kind of requests, not multiple piped bash - both for clarity and stability and readability
There was a problem hiding this comment.
Okay np, I addressed it
This PR will fix the NODEPOOL_NAME after openshift#60670 has been merged for running the test cases. Here we're adjusting the hcp-cnf jobs cron jobs and putting the maximum timeout which is 8 hours per job, so we will be able to execute also the additional test cases Signed-off-by: Roy Shemtov <[email protected]>
rshemtov13
force-pushed
the
telcov10n-hcp-cnf-adjust-tests
branch
from
e3adf88 to
4be50b8
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@rshemtov13: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshemtov13, shaior The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This PR will fix the NODEPOOL_NAME after #60670 has been merged for running the test cases. Here we're adjusting the hcp-cnf jobs cron jobs and putting the maximum timeout which is 8 hours per job, so we will be able to execute also the additional test cases