Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-20487: update egressFWTestE2E image which contains ping binary #28408

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

routerhan
Copy link
Contributor

This PR update the image to use a non-nfs image, since we did not see any reference using nfs image, the test just trys to ping and curl things. And it also fixes the missing ping binary issue on s390x.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2023
@openshift-ci-robot
Copy link

@routerhan: This pull request references Jira Issue OCPBUGS-20487, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR update the image to use a non-nfs image, since we did not see any reference using nfs image, the test just trys to ping and curl things. And it also fixes the missing ping binary issue on s390x.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 20, 2023
@routerhan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@routerhan: This pull request references Jira Issue OCPBUGS-20487, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@routerhan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@routerhan: This pull request references Jira Issue OCPBUGS-20487, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@routerhan
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 24, 2023
@openshift-ci-robot
Copy link

@routerhan: This pull request references Jira Issue OCPBUGS-20487, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @djslavens

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@routerhan
Copy link
Contributor Author

/retest

Copy link

@djslavens djslavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@routerhan
Copy link
Contributor Author

/assign @knobunc

@routerhan
Copy link
Contributor Author

/assign @jaypoulz

@routerhan
Copy link
Contributor Author

/assign @tvardema

@jaypoulz
Copy link
Contributor

jaypoulz commented Dec 4, 2023

/retest-required

@jaypoulz
Copy link
Contributor

jaypoulz commented Dec 4, 2023

/lgtm

@Prashanth684
Copy link

/cc @dcbw @knobunc

@openshift-ci openshift-ci bot requested review from dcbw and knobunc December 18, 2023 16:10
@jaypoulz
Copy link
Contributor

/retest-required

@routerhan
Copy link
Contributor Author

/retest

@danwinship
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, djslavens, jaypoulz, routerhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

@routerhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade ba5bd82 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 92d04bb into openshift:master Jan 19, 2024
21 of 22 checks passed
@openshift-ci-robot
Copy link

@routerhan: Jira Issue OCPBUGS-20487: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20487 has been moved to the MODIFIED state.

In response to this:

This PR update the image to use a non-nfs image, since we did not see any reference using nfs image, the test just trys to ping and curl things. And it also fixes the missing ping binary issue on s390x.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-tests-container-v4.16.0-202401200231.p0.g92d04bb.assembly.stream for distgit openshift-enterprise-tests.
All builds following this will include this PR.

@routerhan routerhan deleted the OCPBUGS-20487 branch January 23, 2024 12:22
@werled
Copy link

werled commented Apr 26, 2024

/cherry-pick release-4.14

@werled
Copy link

werled commented Apr 26, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@werled: new pull request created: #28745

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@werled: new pull request created: #28746

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet