Test orc2 #5452
Draft
Test orc2 #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
area/api
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MaysaMacedo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
area/cli
MaysaMacedo
force-pushed
the
test-orc2
branch
from
23a2165 to
80cba4d
Compare
openshift-merge-robot
removed
the
needs-rebase
EmilienM
reviewed
Jan 21, 2025
| @@ -162,6 +162,9 @@ func reconcileOpenStackImageSpec(hcluster *hyperv1.HostedCluster, openStackImage | |||
| }, | |||
| }, | |||
| } | |||
| if hcluster.Annotations[hyperv1.CleanupOrcImageResourcesAnnotation] == "false" { | |||
| openStackImageSpec.ManagedOptions.OnDelete = "detach" | |||
There was a problem hiding this comment.
we should use the type from ORC if it's possible.
Instead of forcing the users to provide an existing OpenStack Glance image, we now let our CAPI provider to upload the image used in the release payload and handle its lifecycle with ORC.
This commit updates the openstack image name to contain the release image version.
The ORC objects should be created in the same namespace as the CAPO deployment, otherwise CAPO won't see any ORC object to handle.
This commit updates the ownerReference of the ORC Image to point to the openstack Cluster object. This is necessary because the resource that the ORC Image depends on should be in the same namespace as the ORC Image object.
MaysaMacedo
force-pushed
the
test-orc2
branch
from
80cba4d to
716ea4c
Compare
MaysaMacedo
force-pushed
the
test-orc2
branch
from
716ea4c to
6cc6657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist