-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-48626: openstack: add DNS option to CLI #5446
base: main
Are you sure you want to change the base?
Conversation
@EmilienM: This pull request references Jira Issue OCPBUGS-48626, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
35fe0cd
to
8c5d99b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice UX improvement.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar, EmilienM The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow the users to provide the DNS nameservers that will be used when creating the OpenStack subnets. In some environments where DNS forwarding is not enabled, the subnet needs to have DNS nameservers for external resolution, otherwise the Nodepools won't be able to e.g. reach the ignition endpoint. This was already possible before by rendering the HostedCluster spec first but now it's possible to do it via the CLI for a better UX, since this option might be used by a majority of our customers.
8c5d99b
to
6ecceb4
Compare
New changes are detected. LGTM label has been removed. |
/jira refresh |
@EmilienM: This pull request references Jira Issue OCPBUGS-48626, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Allow the users to provide the DNS nameservers that will be used when
creating the OpenStack subnets.
In some environments where DNS forwarding is not enabled, the subnet
needs to have DNS nameservers for external resolution, otherwise the
Nodepools won't be able to e.g. reach the ignition endpoint.
This was already possible before by rendering the HostedCluster spec
first but now it's possible to do it via the CLI for a better UX, since
this option might be used by a majority of our customers.