Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48626: openstack: add DNS option to CLI #5446

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilienM
Copy link
Member

What this PR does / why we need it:

Allow the users to provide the DNS nameservers that will be used when
creating the OpenStack subnets.
In some environments where DNS forwarding is not enabled, the subnet
needs to have DNS nameservers for external resolution, otherwise the
Nodepools won't be able to e.g. reach the ignition endpoint.

This was already possible before by rendering the HostedCluster spec
first but now it's possible to do it via the CLI for a better UX, since
this option might be used by a majority of our customers.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 20, 2025
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-48626, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

Allow the users to provide the DNS nameservers that will be used when
creating the OpenStack subnets.
In some environments where DNS forwarding is not enabled, the subnet
needs to have DNS nameservers for external resolution, otherwise the
Nodepools won't be able to e.g. reach the ignition endpoint.

This was already possible before by rendering the HostedCluster spec
first but now it's possible to do it via the CLI for a better UX, since
this option might be used by a majority of our customers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Jan 20, 2025
@openshift-ci openshift-ci bot added the area/testing Indicates the PR includes changes for e2e testing label Jan 20, 2025
Copy link

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX improvement.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bshephar, EmilienM
Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2025
Allow the users to provide the DNS nameservers that will be used when
creating the OpenStack subnets.
In some environments where DNS forwarding is not enabled, the subnet
needs to have DNS nameservers for external resolution, otherwise the
Nodepools won't be able to e.g. reach the ignition endpoint.

This was already possible before by rendering the HostedCluster spec
first but now it's possible to do it via the CLI for a better UX, since
this option might be used by a majority of our customers.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2025
@EmilienM
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link

@EmilienM: This pull request references Jira Issue OCPBUGS-48626, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-4-18 6ecceb4 link true /test e2e-aws-4-18
ci/prow/e2e-aws-upgrade-hypershift-operator 6ecceb4 link true /test e2e-aws-upgrade-hypershift-operator
ci/prow/verify 6ecceb4 link true /test verify
ci/prow/images 6ecceb4 link true /test images
ci/prow/e2e-aws 6ecceb4 link true /test e2e-aws
ci/prow/e2e-aks-4-18 6ecceb4 link true /test e2e-aks-4-18
ci/prow/e2e-aks 6ecceb4 link true /test e2e-aks
ci/prow/e2e-kubevirt-aws-ovn-reduced 6ecceb4 link true /test e2e-kubevirt-aws-ovn-reduced

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation area/testing Indicates the PR includes changes for e2e testing jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants