Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOSTEDCP-2176: Enable unused & ineffassign linters in golangci-lint #5418

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

HOSTEDCP-2176: Enable unused & ineffassign linters in golangci-lint #5418

wants to merge 3 commits into from
+7 −101

Conversation

bryan-cox
Copy link
Member

What this PR does / why we need it:
This PR:

  • This commit enables unused and ineffassign in golangci-lint, which checks Go code for unused constants, variables, functions and types and ineffectual assignments respectively.
  • Fixes the errrors found by those linters.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-2176

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@bryan-cox
Enable unused & ineffassign in golangci-lint
85b3957 
This commit enables unused and ineffassign in golangci-lint, which checks
Go code for unused constants, variables, functions and types and
ineffectual assignments respectively.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
Remove unused var and funcs found by unused linter
c67c8ac 
This commit removes the unused variables and functions found by the
"unused" linter.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
Fix errors found by ineffassign linter
5627aa3 
This commit fixes the errors found by the ineffassign linter.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox bryan-cox changed the title Hostedcp 2176 enable unused HOSTEDCP-2176: Enable unused & ineffassign linters in golangci-lint Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@bryan-cox: This pull request references HOSTEDCP-2176 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.19." or "openshift-4.19.", but it targets "4.18" instead.

In response to this:

What this PR does / why we need it:
This PR:

  • This commit enables unused and ineffassign in golangci-lint, which checks Go code for unused constants, variables, functions and types and ineffectual assignments respectively.
  • Fixes the errrors found by those linters.

Which issue(s) this PR fixes:
Fixes HOSTEDCP-2176

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from enxebre and hasueki January 17, 2025 14:23
@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing labels Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jan 17, 2025
@bryan-cox
Copy link
Member Author

/test verify

@bryan-cox bryan-cox force-pushed the HOSTEDCP-2176-enable-unused branch from 8f291e1 to 5627aa3 Compare January 17, 2025 18:28
@bryan-cox
Copy link
Member Author

/retest

3 similar comments
@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/retest

@bryan-cox
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@devguyio
Copy link
Contributor

/hold

Let's get #4999 in first.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2025
@bryan-cox
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@hasueki hasueki Awaiting requested review from hasueki

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryan-cox @openshift-ci-robot @devguyio