osgarchive shouldn't fail silently to add files to the archive #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osgarchive may fail to add files to archives for various reasons, and it used to fail silently, making you think that it worked just fine, only to realize the problem when you listed the archive and some contents weren't there. This is a very simple change to check the result and report it in case the file wasn't saved in the archive.
poelmanc
reviewed
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osgarchive may fail to add files to archives for various reasons, and it used to fail silently, making you think that it worked just fine, only to realize the problem when you listed the archive and some contents weren't there. This is a very simple change to check the result and report it in case the file wasn't saved in the archive.