Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more ways to build with dependency to collada-dom library (Debian/Ubuntu/Others) #1171

Open
wants to merge 1 commit into
base: OpenSceneGraph-3.6
Choose a base branch
from

Conversation

psi29a
Copy link

@psi29a psi29a commented Nov 15, 2022

  1. Add more paths to find collada library. Existing onces ignore the default install location defined here.
  2. Find collada dependencies only when found static library. If it's only dynamic library, all dependencies are linked to it and there is no need to find them. Attempt to do so may fail because of locations mismatch. CMakeModules/FindCOLLADA.cmake supports only very specific locations for them.

A similar one is done here: pull request

Note: I've already been carrying these fixes on Debian and Ubuntu as well in our static builds for OpenMW. Others also make use of the patch to work around the issue of how the collada-dom is included. It would be great to have this in OpenSceneGraph-3.6

Support more ways to build with dependency to collada-dom library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant