Add appropriate indentation when knit_print() stopping rule list
#837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,6 +121,18 @@ test_that("knit_print.StoppingList works correctly", { | |||
| "- ≥ 20 patients dosed: If 20 or more participants have been treated.\n\n\n\n" | |||
There was a problem hiding this comment.
You will also need to check that the HTML files in /testthat/snaps/helpers_knitr have updated correctly. They are created (and checked) at line 90 of /testthat/test-helpers_knitr.R.
This patch adjust the preamble of `knit_print()` output for `StoppingList`, `StoppingAny` and `StoppingAll` according to the length of stop list. For `StoppingList`, the premable is adjusted according to whether the length of stop list is 1 or higher. And the wording "rule" or "rules" are used. For `StoppingAny` and `StoppingAll`, the preamble is adjusted accroding to the length of stop list being 1, 2 or more. And the wording "this"/"either"/"any" or "this"/"both"/"all" and "rule"/"rules" are used accordingly.
|
I've also updated this PR to address the nice-to-haves in #836 |
Thank you. @danielinteractive I'm happy with this PR. Would you approve, please? |
…ian/crmPack into knit_print_stoppinglist_indent
|
Just add some new testing code for |
danielinteractive
approved these changes
Jun 26, 2024
|
here we cannot perform all the checks because it is a PR from a forked repo. Therefore merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Padding spaces to the beginning when
knit_print()ing StoppingList so that nestedStoppingListwill have appropriate indent levels when rendered.Fixes #836