Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for DomainTableModel #159

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fixes for DomainTableModel #159

merged 2 commits into from
Oct 23, 2024

Conversation

pshriwise
Copy link
Collaborator

Fixes #156.

Issues addressed:

  • Qt.ItemFlag attributes no longer convert to int
  • Right-click to reset resulted in a None color value. It should now reset to the default color.

fnovais11
fnovais11 approved these changes Oct 22, 2024
View reviewed changes
Copy link

@fnovais11 fnovais11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, thank you @pshriwise

paulromano
paulromano approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pshriwise!

@paulromano paulromano merged commit a96872c into openmc-dev:develop Oct 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnovais11 fnovais11 fnovais11 approved these changes

@paulromano paulromano paulromano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to change material color in "Color Options..." menu does not work
3 participants
@pshriwise @paulromano @fnovais11