-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nascent source site plot capability. #131
Conversation
Nice to see this PR, I remember a few people where asking for this on the slack channel a while back. I'm keen to mirror this functionality on the python api if that is ok |
Perhaps a variable could be added for number of source samples ( |
43aeb08
to
cf25686
Compare
I built this out a little bit today and I'm pretty happy with it now. The animation below shows an annular |
A couple of features to be added yet I suppose, but I'd call this a good base for the feature and wouldn't mind seeing it merged as-is |
@pshriwise I ended up just forging ahead and implementing the changes we talked about today. Let me know if you're happy with how it looks/functions and if so, we can go ahead and merge. Thanks for adding this feature! |
@bohmt so you can use this once it's merged. |
This feature is a little rough still but it adds the ability to plot source sites on top of the current view. All sites are plotted whether they're on the slice plane or not. There are a number of things I'd want to add (see below) before incorporating this, but it has a significant amount in place so I thought I'd create a draft PR at least.
See utilization in openmc-dev/openmc#2857
TODO: