OPEN-5105: Changes to support monitoring data ingestion without InferencePipelineData objects #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test the other methods that rely on the |
Parthib
force-pushed
the
parthib/monitoring-client
branch
from
4b3b959 to
40ca4dc
Compare
|
@gustavocidornelas they seem to work fine |
Parthib
force-pushed
the
parthib/monitoring-client
branch
from
40ca4dc to
a1f6c9c
Compare
…encePipelineData objects
Parthib
force-pushed
the
parthib/monitoring-client
branch
from
a1f6c9c to
bfa7971
Compare
whoseoyster
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We now store information related to monitoring data uploads in a way such that we don't need to create InferencePipelineData objects. To accomplish this, we need to request presigned-urls from a separate endpoint specific to inferencePipeline data.
See https://github.com/openlayer-ai/openlayer/pull/1229 for more information.
Testing
Ran Cid's monitoring quickstart notebook.