Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers #609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viragpurnam
Copy link
Collaborator

@viragpurnam viragpurnam commented Nov 15, 2024

Fixed the launchers, JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/609/head:pull/609
$ git checkout pull/609

Update a local copy of the PR:
$ git checkout pull/609
$ git pull https://git.openjdk.org/jmc.git pull/609/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 609

View PR using the GUI difftool:
$ git pr show -t 609

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/609.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2024

👋 Welcome back vpurnam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@viragpurnam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294: Missing plugins in JMC-Eclipse-plug-ins, JMC-Eclipse and JMC-RCP-plug-ins launchers

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label Nov 15, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2024

Webrevs

@openjdk openjdk bot added the ready label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants