Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8219: Missing coverage in application reports #562

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented May 3, 2024

This PR fixes (&cleans up) the coverage reports under jmc/application.

The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.

Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.

The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8219: Missing coverage in application reports (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562
$ git checkout pull/562

Update a local copy of the PR:
$ git checkout pull/562
$ git pull https://git.openjdk.org/jmc.git pull/562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 562

View PR using the GUI difftool:
$ git pr show -t 562

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/562.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 3, 2024

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 3, 2024

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8219: Missing coverage in application reports

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr label May 3, 2024
@mlbridge
Copy link

mlbridge bot commented May 3, 2024

Webrevs

@aptmac
Copy link
Member Author

aptmac commented May 3, 2024

Ah right, no surefireargline if it's being run without coverage, so that's tanking the tests.

@openjdk
Copy link

openjdk bot commented May 27, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2024

@aptmac This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Jun 27, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the ready label Jul 1, 2024
@aptmac
Copy link
Member Author

aptmac commented Jul 2, 2024

Updated the branch to sit on-top of master to pull in the new Jolokia feature. This also required the addition of the tycho.testArgLine.local to the argLine used when running the tests so the coverage could be recorded.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 30, 2024

@aptmac This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@thegreystone
Copy link
Member

Branch has conflicts.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 6, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 26, 2024

@aptmac Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@aptmac
Copy link
Member Author

aptmac commented Sep 26, 2024

Trying these checks again, locally it ran fine and then it ran cleanly after nuking my local m2 and starting again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants