-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332257: Shenandoah: Move evacuation methods to implementation file #19240
8332257: Shenandoah: Move evacuation methods to implementation file #19240
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, as long as performance data does not show any regressions in evac times.
/integrate No regressions in performance tests on x86 or aarch64. |
Going to push as commit de57d4b.
Your commit was automatically rebased without conflicts. |
@earthling-amzn Pushed as commit de57d4b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This refactoring moves a large, complex function out of an include header. This improves build times and facilitates changes in the generational mode branch.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19240/head:pull/19240
$ git checkout pull/19240
Update a local copy of the PR:
$ git checkout pull/19240
$ git pull https://git.openjdk.org/jdk.git pull/19240/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19240
View PR using the GUI difftool:
$ git pr show -t 19240
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19240.diff
Webrev
Link to Webrev Comment