Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed #19228

Closed
wants to merge 1 commit into from

Conversation

xiaotaonan
Copy link

@xiaotaonan xiaotaonan commented May 14, 2024

Code in GenFullCP is still disabled after JDK-8079697 was fixed
note:I have not found any relevant information on why ClassWriter.COMPUTE_FRAMES is disabled in JDK-8079697.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19228/head:pull/19228
$ git checkout pull/19228

Update a local copy of the PR:
$ git checkout pull/19228
$ git pull https://git.openjdk.org/jdk.git pull/19228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19228

View PR using the GUI difftool:
$ git pr show -t 19228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19228.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@xiaotaonan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@xiaotaonan
Copy link
Author

/label hotspot-gc

@openjdk
Copy link

openjdk bot commented May 14, 2024

@xiaotaonan
The hotspot-gc label was successfully added.

@xiaotaonan
Copy link
Author

/label hotspot

@openjdk
Copy link

openjdk bot commented May 14, 2024

@xiaotaonan
The hotspot label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@stefank
Copy link
Member

stefank commented May 15, 2024

This is not related to GC code, could you remove the hotspot-gc label you added?

@xiaotaonan
Copy link
Author

/unlabel hotspot-gc

@openjdk
Copy link

openjdk bot commented May 15, 2024

@xiaotaonan Unknown command unlabel - for a list of valid commands use /help.

@xiaotaonan
Copy link
Author

/help

@openjdk
Copy link

openjdk bot commented May 15, 2024

@xiaotaonan Available commands:

  • approval - request for maintainer's approval
  • approve - null
  • author - sets an overriding author to be used in the commit when the PR is integrated
  • backport - create a backport
  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • jep - require a JDK Enhancement Proposal (JEP) for this pull request
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests

@xiaotaonan
Copy link
Author

/label hotspot-gc

@openjdk
Copy link

openjdk bot commented May 15, 2024

@xiaotaonan The hotspot-gc label was already applied.

@xiaotaonan
Copy link
Author

/label -remove hotspot-gc

@openjdk
Copy link

openjdk bot commented May 15, 2024

@xiaotaonan
The label remove is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@xiaotaonan
Copy link
Author

/label remove hotspot-gc

@openjdk
Copy link

openjdk bot commented May 15, 2024

@xiaotaonan
The hotspot-gc label was successfully removed.

@xiaotaonan
Copy link
Author

@stefank @mdinacci @hns @landonf

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2024

@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 13, 2024

@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants