-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301464: Code in GenFullCP is still disabled after JDK-8079697 was fixed #19228
Conversation
👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@xiaotaonan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label hotspot-gc |
@xiaotaonan |
/label hotspot |
@xiaotaonan |
This is not related to GC code, could you remove the hotspot-gc label you added? |
/unlabel hotspot-gc |
@xiaotaonan Unknown command |
/help |
@xiaotaonan Available commands:
|
/label hotspot-gc |
@xiaotaonan The |
/label -remove hotspot-gc |
@xiaotaonan
|
/label remove hotspot-gc |
@xiaotaonan |
@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@xiaotaonan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Code in GenFullCP is still disabled after JDK-8079697 was fixed
note:I have not found any relevant information on why ClassWriter.COMPUTE_FRAMES is disabled in JDK-8079697.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19228/head:pull/19228
$ git checkout pull/19228
Update a local copy of the PR:
$ git checkout pull/19228
$ git pull https://git.openjdk.org/jdk.git pull/19228/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19228
View PR using the GUI difftool:
$ git pr show -t 19228
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19228.diff
Webrev
Link to Webrev Comment