Load external shader file at compile time via @:glFragmentSourceFile and @:glVertexSourceFile #2597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to load an external file to be used as a shader (fragment or vertex).
Usage:
This could help separate the actual GLSL code from its OpenFL management. Most IDEs can correctly highlight/format the syntax of an external shader file, while long strings (as the
@:glFragmentSource()
argument) are usually rendered as a uniform color and must be formatted by hand; so this could be a nice quality of life change.This PR is changing the
ShaderMacro.build()
function so that:glFragmentSourceFile
,:glFragmentSourceFile
,glVertexSourceFile
, and:glVertexSourceFile
;glFragmentSource
/glVertexSource
, overriding the@:glFragmentSource
/@:glVertexSource
argument (if defined).