Implement controller rumble support to ui/Gamepad #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this as working! |
player-03
reviewed
Jan 5, 2024
player-03
reviewed
Jan 5, 2024
| gameController = other.gameController; | ||
| other.gameController = temp; | ||
| return *this; | ||
| } |
There was a problem hiding this comment.
Wouldn't it be clearer to define a Swap() function instead of overriding an operator?
There was a problem hiding this comment.
was this the final thing that needed to be addressed for this PR?
There was a problem hiding this comment.
I don't know about "final" or otherwise. This was just something I was curious about.
There was a problem hiding this comment.
fwiw, op overloading does seem to make, otherwise seemingly straightforward code have oddly obfuscated behavior
player-03
reviewed
Jan 5, 2024
* whitespacing real.. please! * nativecffi rumble thing fix lol
|
many of the whitespacing/formatting issues should be fixed up now @player-03 and the changes should be easier to parse through and read! |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a controller rumble method to the ui/Gamepad class.
At this time, it only implements the native/SDL2 backend. HTML5 should be simple as well, although browser support for rumble is lacking as of writing this.
Closes #869