This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Missing EIP transitions for dev chain spec #11836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
approved these changes
Jul 30, 2020
| "eip1344Transition": "0x0", | ||
| "eip1706Transition": "0x0", | ||
| "eip1884Transition": "0x0", | ||
| "eip2028Transition": "0x0", | ||
| "wasmActivationTransition": "0x0" |
There was a problem hiding this comment.
We should also remove parity-wasm if the goal is to make dev chain same as mainnet.
There was a problem hiding this comment.
I don’t know if that’s a goal, but without the above eips some instructions were def missing
sorpaas
added
A6-mustntgrumble 💦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the missing EIP transitions when testing a contract using the
SELFBALANCEinstruction. I don't see most of these in the docs, but they are present in thefoundation.jsonchain spec. Most of these are related to the Istanbul hard fork