Validate file size before upload #7383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpadgett
requested changes
May 26, 2024
Comment on lines
+20
to
+21
| totalSize += fileInput.files[i].size; | ||
| } |
There was a problem hiding this comment.
The MAX_FILE_SIZE is the maximum allowed size for each individual file, not the combined total size of all files.
So this verification is invalid for our purposes.
Comment on lines
-14
to
+35
| <form class="form" method="post" enctype="multipart/form-data" action="{$FORM_ACTION}" onsubmit="return top.restoreSession()"> | ||
| <form class="form" method="post" enctype="multipart/form-data" action="{$FORM_ACTION}" onsubmit="return checkFileSize()"> |
There was a problem hiding this comment.
You still need to run restoreSession before file check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7382
Short description of what this resolves:
This pull request addresses the issue where OpenEMR fails to display an error message when attempting to upload large files, leaving users unaware of the upload failure.
Changes proposed in this pull request: