Fix: delete entry in immunization #7346
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the delete class to the button which is used by the java script function to select the delete button.
sjpadgett
approved these changes
May 26, 2024
| @@ -822,7 +822,7 @@ function saveImmunizationObservationResults($id, $immunizationdata) | |||
|
|
|||
| echo "<td><input type='checkbox' class='error' id='" . attr($row["id"]) . "' value='" . xlt('Error') . "' " . $checkbox . " /></td>"; | |||
|
|
|||
| echo "<td><button type='button' class='btn btn-danger btn-delete' id='" . attr($row["id"]) . "' value='" . xlt('Delete') . "'>" . xlt('Delete') . "</button></td>"; | |||
| echo "<td><button type='button' class='delete btn btn-danger btn-delete' id='" . attr($row["id"]) . "' value='" . xlt('Delete') . "'>" . xlt('Delete') . "</button></td>"; | |||
There was a problem hiding this comment.
This trigger class must have been removed during one of the many restyling forays. This is a bug fix so looks good to me.
sjpadgett
pushed a commit
to sjpadgett/openemr
that referenced
this pull request
May 26, 2024
Added the delete class to the button which is used by the java script function to select the delete button. (cherry picked from commit 707f69a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the delete class to the button which is used by the java script function to select the delete button.
Fixes #7345
Short description of what this resolves:
It fixes the issue with the delete button in the immunization list of a patient.
Changes proposed in this pull request:
Adding delete to the class attribute of the button element solves this issue because this triggers the javascript onclick function responsible for deleting the immunization entry.