edx_notes_api config for native image #993
Conversation
…hub.com/openedx/devstack into zshkoor/Ansible-to-Docker-edx-notes-api
| RESULTS_DEFAULT_SIZE: 25 | ||
| RESULTS_MAX_SIZE: 250 | ||
| SECRET_KEY: CHANGEME | ||
| USERNAME_REPLACEMENT_WORKER: OVERRIDE THIS WITH A VALID USERNAME |
docker-compose.yml
Outdated
| @@ -390,6 +390,7 @@ services: | |||
| - lms | |||
| - mysql57 | |||
| image: edxops/notes:${OPENEDX_RELEASE:-latest} | |||
There was a problem hiding this comment.
We have to use new Ansible free image here and test it before we merge this PR
There was a problem hiding this comment.
Can you please help me to find it how you have done it before for other PRs?
I followed analytics PR, so is there anything which I'm missing from analytics PR?
There was a problem hiding this comment.
We will need to change the image specified here currently with the new Ansible free image once we merge the PR in notes-api repository
There was a problem hiding this comment.
image name changed
docker-compose.yml
Outdated
| @@ -407,6 +408,9 @@ services: | |||
| ENABLE_DJANGO_TOOLBAR: 1 | |||
| ELASTICSEARCH_URL: "http://edx.devstack.elasticsearch710:9200" | |||
| ELASTICSEARCH_DSL: "http://edx.devstack.elasticsearch710:9200" | |||
| volumes: | |||
| - /edx/var/edx_notes_api/ | |||
There was a problem hiding this comment.
This wasn't present before. We shouldn't add anything not related to our work
There was a problem hiding this comment.
but you have it in your analytics PR
https://github.com/openedx/devstack/pull/976/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3
There was a problem hiding this comment.
I didn't add it as part of my PR. We simply don't need it for notes-api if it wasn't specified already
There was a problem hiding this comment.
thanks, verified it. It was not there before.
| @@ -453,6 +453,9 @@ dev.shell.analyticsapi: | |||
| dev.shell.insights: | |||
| docker-compose exec insights env TERM=$(TERM) bash -c 'eval $$(source /edx/app/insights/insights_env; echo PATH="$$PATH";) && /bin/bash' | |||
|
|
|||
| dev.shell.edx_notes_api: | |||
There was a problem hiding this comment.
If there is no specific make target for note_api then according to my understanding this command will be executed which means there should be no need to add this command explicitly. Can you please try this theory too when testing the Ansible free image
I've completed each of the following or determined they are not applicable: