fix(odd-platform-ui): fix ui build for windows #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind: bug
This comment has been minimized.
This comment has been minimized.
|
AndreyNenashev
approved these changes
Feb 6, 2024
| @@ -9,12 +9,12 @@ | |||
| "build": "pnpm generate && tsc --noEmit && vite build", | |||
| "test": "vitest", | |||
| "tsc": "tsc", | |||
| "generate": "docker run -v `pwd`/..:/mnt -w /mnt --rm openapitools/openapi-generator-cli:v5.1.1 generate -c odd-platform-ui/openapi-config.yaml", | |||
| "generate": "chmod u+x ./generate.sh && ./generate.sh", | |||
There was a problem hiding this comment.
Did you try to run pnpm build or gradle build to make sure that gradle can generate models and build ui too?
There was a problem hiding this comment.
yes, both pnpm build and gradle build work
workshur
approved these changes
Feb 6, 2024
| @@ -9,12 +9,12 @@ | |||
| "build": "pnpm generate && tsc --noEmit && vite build", | |||
| "test": "vitest", | |||
| "tsc": "tsc", | |||
| "generate": "docker run -v `pwd`/..:/mnt -w /mnt --rm openapitools/openapi-generator-cli:v5.1.1 generate -c odd-platform-ui/openapi-config.yaml", | |||
| "generate": "chmod u+x ./generate.sh && ./generate.sh", | |||
There was a problem hiding this comment.
Hm. Running bash scripts is not looks safe from contributor's prospective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
How to test
run pnpm build on windows