Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved segmentation sample #25559

Merged
merged 4 commits into from May 15, 2024
Merged

Improved segmentation sample #25559

merged 4 commits into from May 15, 2024
+136 −100

Conversation

gursimarsingh
Copy link

#25006

This pull request replaces caffe models with onnx for the dnn segmentation sample in cpp and python
fcnresnet-50 and fcnresnet-101 has been replaced
u2netp (foreground-background) segmentation onnx model has been added U2NET

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@gursimarsingh gursimarsingh added category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5 labels May 7, 2024
@gursimarsingh gursimarsingh added this to the 5.0 milestone May 7, 2024
asmorkalov
asmorkalov approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

asmorkalov
asmorkalov reviewed May 14, 2024
View reviewed changes
samples/dnn/models.yml
sha1: "1bb0c7e0034038969aecc6251166f1612a139230"
model: "fcn-resnet50-12.onnx"
mean: [103.5, 116.2, 123.6]
scale: 0.019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample is missing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmorkalov It is there in line 254 https://github.com/gursimarsingh/opencv/blob/6314b2cb5c3e2c9c25be8382bfaa82b08acf4c86/samples/dnn/models.yml#L254

@asmorkalov asmorkalov self-assigned this May 15, 2024
@asmorkalov asmorkalov merged commit 48c31bd into opencv:5.x May 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@asmorkalov asmorkalov

Labels
category: samples cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) OpenCV5
Projects
OpenCV 5.0
Status: Done
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gursimarsingh @asmorkalov