Code review fixes.

modules/dnn/test/test_onnx_conformance_layer_filter_opencv_all_denylist.inl.hpp

@@ -1,17 +1,13 @@
-// "test_add_uint8", // output size mismatch in NORMASSERT
 "test_averagepool_2d_pads_count_include_pad", // wrong output
 "test_averagepool_2d_precomputed_pads_count_include_pad", // wrong output
 "test_averagepool_2d_same_lower", // wrong output
 "test_cast_FLOAT_to_STRING", // Unsupported type in function 'parseCast'
 "test_cast_STRING_to_FLOAT", // unexception during net.forward() call
 "test_castlike_FLOAT_to_STRING_expanded", // Unsupported type in function 'parseCast'
 "test_castlike_STRING_to_FLOAT_expanded", // unexception during net.forward() call
-// "test_div_uint8", // output type mismatch
 "test_maxpool_2d_dilations", // output size mismatch in NORMASSERT
 "test_maxpool_2d_same_lower", // wrong output
 "test_maxpool_2d_uint8", // output type mismatch
 "test_maxpool_with_argmax_2d_precomputed_strides", // wrong output
 "test_maxunpool_export_with_output_shape", // unexception during net.forward() call
-// "test_mul_uint8", // output type mismatch
-// "test_sub_uint8", // output type mismatch
 "test_upsample_nearest", // Dimension mismatch of input

modules/dnn/test/test_onnx_conformance_layer_parser_denylist.inl.hpp

@@ -32,7 +32,6 @@
 "test_bitshift_right_uint64", // Issue::Unsuppoted data type
 "test_bitshift_right_uint8", // Issues::Layer::Can't create layer "onnx_node_output_0!z" of type "BitShift" in function 'getLayerInstance'
 "test_cast_BFLOAT16_to_FLOAT", // Issue::Unsuppoted data type
-// "test_cast_DOUBLE_to_FLOAT",
 "test_cast_DOUBLE_to_FLOAT16", // Issue::Unsuppoted data type
 "test_cast_FLOAT16_to_DOUBLE", // Issue::Unsuppoted data type
 "test_cast_FLOAT16_to_FLOAT", // Issue::Unsuppoted data type
@@ -93,7 +92,6 @@
 "test_dequantizelinear_axis", // Issue::Parser::Weights are required as inputs
 "test_det_2d", // Issue:: Unkonwn error
 "test_det_nd", // Issue:: Unkonwn error
-// "test_div_example",
 "test_dropout_default_mask", // Issue:: Unsupported data type BOOL
 "test_dropout_default_mask_ratio", // Issue:: Unsupported data type BOOL
 "test_dynamicquantizelinear", // Issue:: Unkonwn error
@@ -117,8 +115,6 @@
 "test_gemm_all_attributes", // Issue::Wrong output
 "test_gemm_alpha", // Issue::Wrong output
 "test_gemm_beta", // Issue::Wrong output
-// "test_gemm_default_matrix_bias",
-// "test_gemm_default_no_bias",
 "test_gemm_default_scalar_bias", // Issue::Wrong output
 "test_gemm_default_single_elem_vector_bias", // Issue::Wrong output
 "test_gemm_default_vector_bias", // Issue::Wrong output
@@ -173,77 +169,44 @@
 "test_lstm_with_initial_bias", // ---- same as above ---
 "test_lstm_with_peepholes", // ---- same as above ---
 "test_matmulinteger", // Issues::Layer does not exist. Can't create layer "onnx_node_output_0!Y" of type "MatMulInteger" in function 'getLayerInstance'
-// "test_max_example",
-// "test_max_float16",
-// "test_max_float32",
-// "test_max_float64",
 "test_max_int16", // Issue:: Unsupported data type
-// "test_max_int32",
-// "test_max_int64",
-// "test_max_int8", // Issue:: Unkonwn error
-// "test_max_one_input",
-// "test_max_two_inputs",
 "test_max_uint16", // Issue:: Unsupported data type
 "test_max_uint32", // Issue:: Unsupported data type
 "test_max_uint64", // Issue:: Unsupported data type
-// "test_max_uint8", // Issue:: Unkonwn error
 "test_mean_example", // Issues::Layer does not exist. Can't create layer "onnx_node_output_0!result" of type "Mean" in function 'getLayerInstance'
 "test_mean_one_input", // ---- same as above ---
 "test_mean_two_inputs", // ---- same as above ---
-// "test_min_example",
-// "test_min_float16",
-// "test_min_float32",
-// "test_min_float64",
 "test_min_int16", // Issue:: Unsupported data type
-// "test_min_int32",
-// "test_min_int64",
-// "test_min_int8", // Issue:: Unkonwn error
-// "test_min_one_input",
-// "test_min_two_inputs",
 "test_min_uint16", // Issue:: Unsupported data type
 "test_min_uint32", // Issue:: Unkonwn error
 "test_min_uint64", // Issue:: Unsupported data type
-// "test_min_uint8", // Issue:: Unkonwn error
-// "test_mod_broadcast",
-// "test_mod_int64_fmod",
 "test_mod_mixed_sign_int16", // Issue:: Unkonwn error
-// "test_mod_mixed_sign_int32",
-// "test_mod_mixed_sign_int64",
-// "test_mod_mixed_sign_int8", // Issue:: Unkonwn error
 "test_mod_uint16", // Issue:: Unkonwn error
 "test_mod_uint32", // ---- same as above ---
 "test_mod_uint64", // ---- same as above ---
-// "test_mod_uint8", // ---- same as above ---
 "test_momentum", // Issues::Layer does not exist. Can't create layer "onnx_node_output_0!X1_new" of type "ai.onnx.preview.training.Momentum" in function 'getLayerInstance'
 "test_momentum_multiple", // ---- same as above ---
-// "test_mul_example",
 "test_mvn", // Issues::Wrong answer
 "test_mvn_expanded", // Issues::Wrong answer
 "test_nesterov_momentum", // Issues::Layer does not exist (NesterovsAcceleratedGradient) Can't create layer "onnx_node_output_0!X_new" of type "ai.onnx.preview.training.Momentum" in function 'getLayerInstance'
 "test_nllloss_NC", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NC_expanded",
 "test_nllloss_NCd1", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1_expanded",
 "test_nllloss_NCd1_ii", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1_ii_expanded", // Issue:: Unsupported data type
 "test_nllloss_NCd1_mean_weight_negative_ii", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1_mean_weight_negative_ii_expanded", // Issue:: Unsupported data type
 "test_nllloss_NCd1_weight", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1_weight_expanded",
 "test_nllloss_NCd1_weight_ii", // Issue:: Unsupported data type
 "test_nllloss_NCd1_weight_ii_expanded", // Issue:: Unsupported data type
 "test_nllloss_NCd1d2", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1d2_expanded",
 "test_nllloss_NCd1d2_no_weight_reduction_mean_ii", // Issue:: Unsupported data type
 "test_nllloss_NCd1d2_no_weight_reduction_mean_ii_expanded", // Issue:: Unsupported data type
 "test_nllloss_NCd1d2_reduction_mean", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2_reduction_mean_expanded", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2_reduction_sum", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2_reduction_sum_expanded", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2_with_weight", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1d2_with_weight_expanded",
 "test_nllloss_NCd1d2_with_weight_reduction_mean", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1d2_with_weight_reduction_mean_expanded",
 "test_nllloss_NCd1d2_with_weight_reduction_sum", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2_with_weight_reduction_sum_expanded", // Issue::Wrong output on CUDA
 "test_nllloss_NCd1d2_with_weight_reduction_sum_ii", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
@@ -255,7 +218,6 @@
 "test_nllloss_NCd1d2d3d4d5_mean_weight", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
 "test_nllloss_NCd1d2d3d4d5_mean_weight_expanded", // Issue::Wrong output
 "test_nllloss_NCd1d2d3d4d5_none_no_weight", // Issue:: Layer does not exist (NegativeLogLikelihoodLoss, SoftmaxCrossEntropyLoss)
-// "test_nllloss_NCd1d2d3d4d5_none_no_weight_expanded",
 "test_nonmaxsuppression_center_point_box_format", // Issue:: Layer does not exist (NonMaxSuppression)::Can't create layer "onnx_node_output_0!selected_indices" of type "NonMaxSuppression" in function 'getLayerInstance'
 "test_nonmaxsuppression_flipped_coordinates", // ---- same as above ---
 "test_nonmaxsuppression_identical_boxes", // ---- same as above ---
@@ -285,10 +247,6 @@
 "test_or_bcast4v2d", // ---- same as above ---
 "test_or_bcast4v3d", // ---- same as above ---
 "test_or_bcast4v4d", // ---- same as above ---
-// "test_pow",
-// "test_pow_bcast_array",
-// "test_pow_bcast_scalar",
-// "test_pow_example",
 "test_pow_types_float", // Issue:: Unsupported data type
 "test_pow_types_float32_int32", // ---- same as above ---
 "test_pow_types_float32_int64", // ---- same as above ---
@@ -298,7 +256,6 @@
 "test_pow_types_int32_float32", // ---- same as above ---
 "test_pow_types_int32_int32", // ---- same as above ---
 "test_pow_types_int64_float32", // ---- same as above ---
-// "test_pow_types_int64_int64",
 "test_prelu_broadcast", // Issue::Parser:Blob slope not found in const blobs in function 'getBlob' (weights are required as inputs)
 "test_prelu_example", // ---- same as above ---
 "test_qlinearconv", // Issue::Parser: Blob x_scale not found in const blobs in function 'getBlob' (weights are required as inputs)
@@ -466,9 +423,6 @@
 "test_strnormalizer_export_monday_empty_output", // ---- same as above ---
 "test_strnormalizer_export_monday_insensintive_upper_twodim", // ---- same as above ---
 "test_strnormalizer_nostopwords_nochangecase", // Issue:: Parser: Can't create layer "onnx_node_output_0!y" of type "StringNormalizer" in function 'getLayerInstance'
-// "test_sub_example",
-// "test_sum_example",
-// "test_sum_two_inputs",
 "test_tfidfvectorizer_tf_batch_onlybigrams_skip0", // Issue:: Parser: Can't create layer "onnx_node_output_0!Y" of type "TfIdfVectorizer" in function 'getLayerInstance'
 "test_tfidfvectorizer_tf_batch_onlybigrams_skip5", // ---- same as above ---
 "test_tfidfvectorizer_tf_batch_uniandbigrams_skip5", // ---- same as above ---