Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pass of a whitelist that adds labels relevant for aggregation #2719

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

AjayTripathy
Copy link
Contributor

What does this PR change?

  • Support a label whitelist, but leave all labels on

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • Lower prometheus memory impact.

How was this PR tested?

  • Unit tests, run manually on a GKE cluster

Does this PR require changes to documentation?

  • Yes; we should document this feature when ready.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • Still mainly a proposal

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview Apr 28, 2024 11:04pm

Copy link

sonarcloud bot commented Apr 28, 2024

@AjayTripathy AjayTripathy changed the title [DRAFT] initial pass of a whitelist that adds labels relevant for aggregation initial pass of a whitelist that adds labels relevant for aggregation May 15, 2024
@AjayTripathy
Copy link
Contributor Author

@cliffcolvin could we get a review on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant