remove cloud cost and custom cost from cost-model initialization #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sean-Holcomb
force-pushed
the
sth/remove-extra-processess-from-cost-model
branch
from
6898398
to
fe0a15d
Compare
Sean-Holcomb
force-pushed
the
sth/remove-extra-processess-from-cost-model
branch
from
fe0a15d
to
89bfd20
Compare
nikovacevic
approved these changes
May 7, 2024
Signed-off-by: Sean Holcomb <[email protected]>
Sean-Holcomb
force-pushed
the
sth/remove-extra-processess-from-cost-model
branch
from
89bfd20
to
0e71bed
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR modularizes the initialization of processes (or Services) for the cost-model (Kubernetes costs), cloud costs and custom costs. As these processes have limited shared dependencies and may need to run independently, they have been split out to do so. The way in which they have been split allows each Service to build the structures that it requires and register endpoints against a router that is passed to it. The OpenCost executable is then able to run these services using a router that it owns. The OpenCost executable is also able to register additional endpoints that are only relevant to itself and not to other executable that run any of the Services.
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
TODO
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?