Allow cost-model container to run with a read-only root filesystem #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Timmer <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…container Signed-off-by: Kai Timmer <[email protected]>
|
mattray
added
opencost
|
Thanks for the PR, I'm going to need to test it before merging it. I thought we'd already dealt with these, but maybe it was just the opencost-ui container. |
Yes, the last one was just for the UI. I missed this one at that time and only realized afterwards that the same problem exists here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Same as in #2521
I want to be able to use a read-only root file system when running opencost.
Does this PR relate to any other PRs?
Yes, to #2521
How will this PR impact users?
It won't, but now you can mount an emptyDir to
/modelsand setreadOnlyRootFilesystem: truewhich is a requirement in our Kubernetes clusters.IMHO this should fix: #1760