fix: handle overlay xattr opaque bit #538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 73.34% 73.28% -0.06%
==========================================
Files 60 60
Lines 4895 4908 +13
==========================================
+ Hits 3590 3597 +7
- Misses 944 949 +5
- Partials 361 362 +1
|
hallyn
approved these changes
Mar 29, 2024
|
Looks like some delta between current main branch and the project-stacker branch, @rchincha . |
rchincha
force-pushed
the
overlay-opaque
branch
5 times, most recently
from
60783be
to
e7a8957
Compare
hallyn
approved these changes
Mar 29, 2024
Current behavior determines if a path is a whiteout if a overlay char dev is present. Additionally, also check the extended attrs. For files, this is not important: if a file /foo/bar exists in some two layers, then the higher layer's version will replace the lower layer's version whether or not the opaque bit is set. However, directories behave differently. If /foo exists in two layers and no opaque bit is set, then we see the union of their contents. But if the opaque bit is set on the higher layer's version, then we should not see the lower layer's version. So, in that case, create a whiteout /.wh_foo. Signed-off-by: Ramkumar Chinchani <[email protected]>
|
This behavior seems a bit fiddly; can you add a test to make sure it doesn't break in the future? I think that will also help describe what the problem is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior determines if a path is a whiteout if a overlay char dev is present.
Additionally, also check the extended attrs.