Commits on Jul 17, 2024

1. runtime: fail when a poststart hook fails …

   Poststart hooks exist in runc since 2015 [1], and since that time until
   today, if a hook returned an error, runc kills the container.
   
   In 2020, commit c166268 (PR opencontainers#1008) added the following text
   (which became part of runtime-spec release v1.0.2):
   
   > 9. The `poststart` MUST be invoked by the runtime. If any
   > `poststart` hook fails, the runtime MUST log a warning, but the
   > remaining hooks and lifecycle continue as if the hook had succeeded.
   
   Now, this text conflicted with the pre-existing runtime (runc) behavior,
   and it still conflicts with the current runc behavior.
   
   At this point, we can either fix runtimes or the spec.
   
   To my mind, fixing the spec is a better approach, because:
    - initial implementation predates the spec wording by a few years;
    - the wording in the spec was never implemented (in runc);
    - returning an error (and stopping the container) seems like a more
      versatile approach, since a hook can usually choose whether to
      return an error or not.
   
   [1]: opencontainers/runc#392
   
   Signed-off-by: Kir Kolyshkin <[email protected]>

   

   kolyshkin committed Jul 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for c6b3b08
   • Browse repository at this point

   Copy the full SHA

   c6b3b08 View commit details

   Browse the repository at this point in the history