-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs-go/config: add Core Scheduling support #1114
Open
kailun-qin
wants to merge
1
commit into
opencontainers:main
Choose a base branch
from
kailun-qin:add-core-scheduling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,8 @@ type Process struct { | |
OOMScoreAdj *int `json:"oomScoreAdj,omitempty" platform:"linux"` | ||
// SelinuxLabel specifies the selinux context that the container process is run as. | ||
SelinuxLabel string `json:"selinuxLabel,omitempty" platform:"linux"` | ||
// CoreSched specifies the Core Scheduling config options for the container. | ||
CoreSched *LinuxCoreSched `json:"coreSched,omitempty" platform:"linux"` | ||
} | ||
|
||
// LinuxCapabilities specifies the list of allowed capabilities that are kept for a process. | ||
|
@@ -75,6 +77,27 @@ type LinuxCapabilities struct { | |
Ambient []string `json:"ambient,omitempty" platform:"linux"` | ||
} | ||
|
||
// LinuxCoreSched defines the Core Scheduling config options for the container. | ||
type LinuxCoreSched struct { | ||
// Create controls whether to create a new unique cookie for the process in the container. | ||
Create bool `json:"create,omitempty" platform:"linux"` | ||
// ShareTo specifies the PIDs that the core_sched cookie of the current process should push to. | ||
ShareTo *LinuxCoreSchedPids `json:"shareTo,omitempty" platform:"linux"` | ||
// ShareFrom specifies the PIDs that the core_sched cookie of the current process should pull from. | ||
ShareFrom *LinuxCoreSchedPids `json:"shareFrom,omitempty" platform:"linux"` | ||
} | ||
|
||
// LinuxCoreSchedPids defines the PIDs that Core Scheduling supports for setting and copying 'task cookies'. | ||
// 'PID == 0' implies the current process. | ||
type LinuxCoreSchedPids struct { | ||
// Pids are the threads. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean processes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And in which PIDNS? |
||
Pids []int `json:"pids,omitempty" platform:"linux"` | ||
// Tgids are the processes. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Did you mean thread groups? |
||
Tgids []int `json:"tgids,omitempty" platform:"linux"` | ||
// Pgids are the process groups. | ||
Pgids []int `json:"pgids,omitempty" platform:"linux"` | ||
} | ||
|
||
// Box specifies dimensions of a rectangle. Used for specifying the size of a console. | ||
type Box struct { | ||
// Height is the vertical dimension of a box. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "current?