Skip to content

Commit

Permalink
specs-go: mark LinuxMemory.Kernel as deprecated
Browse files Browse the repository at this point in the history
Support for kernel-memory limits was deprecated in the kernel, and documented
as "NOT RECOMMENDED" (or "SHOULD NOT" use) in  v1.1.0-rc.1 through commit
f02cd4a.

This patch marks the field as deprecated in the go implementation of the
spec, so that linters and editors produces a warning and consumers get
notified of its status.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
thaJeztah committed Sep 29, 2023
1 parent c0e9043 commit cabeea7
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions specs-go/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,12 @@ type LinuxMemory struct {
// Total memory limit (memory + swap).
Swap *int64 `json:"swap,omitempty"`
// Kernel memory limit (in bytes).
//
// Deprecated: kernel-memory limits are not supported in cgroups v2, and
// were obsoleted in [kernel v5.4]. This field should no longer be used,
// as it may be ignored by runtimes.
//
// [kernel v5.4]: https://github.com/torvalds/linux/commit/0158115f702b0ba208ab0
Kernel *int64 `json:"kernel,omitempty"`
// Kernel memory limit for tcp (in bytes)
KernelTCP *int64 `json:"kernelTCP,omitempty"`
Expand Down

0 comments on commit cabeea7

Please sign in to comment.