Skip to content

Commit

Permalink
config: simplify final CPU affinity rule
Browse files Browse the repository at this point in the history
Description of execCPUAffinity.final said that if it's not set or empty,
the final affinity is the one of container's cgroup. This was done
because we thought the kernel changes process' CPU affinity to one of
cgroup. It's not the case.

To keep the runtime simple, it makes sense to not do anything if the
final affinity is not explicitly set. This change does just that.

Signed-off-by: Kir Kolyshkin <[email protected]>
  • Loading branch information
kolyshkin committed Jul 17, 2024
1 parent 7017384 commit adaa517
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions config.md
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,9 @@ For Linux-based systems, the `process` object supports the following process-spe
ranges. For example, `0-3,7` represents CPUs 0,1,2,3, and 7.
* **`final`** (string, OPTIONAL) is a list of CPUs the process will be run
on after the transition to container's cgroup. The format is the same as
for `initial`. If omitted or empty, the container's default CPU affinity,
as defined by [cpu.cpus property](./config.md#configLinuxCPUs)), is used.
for `initial`. If omitted or empty, runtime SHOULD NOT change process'
CPU affinity after the process is moved to container's cgroup, and the
final affinity is determined by the Linux kernel.

### <a name="configUser" />User

Expand Down

0 comments on commit adaa517

Please sign in to comment.