Skip to content

Commit

Permalink
Merge pull request #1232 from thaJeztah/go_prestarthook_deprecated
Browse files Browse the repository at this point in the history
specs-go: add missing deprecation comment for Hooks.Prestart
  • Loading branch information
hqhq authored Oct 5, 2023
2 parents c0e9043 + 4005c81 commit ab29785
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions specs-go/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ type Hook struct {
type Hooks struct {
// Prestart is Deprecated. Prestart is a list of hooks to be run before the container process is executed.
// It is called in the Runtime Namespace
//
// Deprecated: use [Hooks.CreateRuntime], [Hooks.CreateContainer], and
// [Hooks.StartContainer] instead, which allow more granular hook control
// during the create and start phase.
Prestart []Hook `json:"prestart,omitempty"`
// CreateRuntime is a list of hooks to be run after the container has been created but before pivot_root or any equivalent operation has been called
// It is called in the Runtime Namespace
Expand Down

0 comments on commit ab29785

Please sign in to comment.