Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum version of golang in readme #4415

Closed
wants to merge 2 commits into from

Conversation

amghazanfari
Copy link
Contributor

In the readme there are two statements

  1. the minimum version of go for runc is v1.21
  2. if you use go v1.22 make sure it's newer than 1.22.4 due to a bug

when i use go v1.21 in Dockerfile for testing I got error

+ exec make localunittest TESTFLAGS=
rm -f libcontainer/dmz/binary/runc-dmz
go generate -tags "seccomp urfave_cli_no_docs" ./libcontainer/dmz
go: go.mod requires go >= 1.22 (running go 1.21.13; GOTOOLCHAIN=local)
make: *** [Makefile:116: runc-dmz] Error 1
make: *** [Makefile:161: unittest] Error 2

but with go v1.22 and v1.23 it was ok. so i change minimum version to 1.22.4 and delete the warning

Signed-off-by:  Amir M. Ghazanfari <[email protected]>
Signed-off-by: Amir M. Ghazanfari <[email protected]>
Signed-off-by: Amir M. Ghazanfari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant