Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update bats-action to v2.1.1 #4412

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

akhilerm
Copy link
Contributor

@akhilerm akhilerm commented Sep 25, 2024

  • bats-core/bats-action installs a few support libraries by default which are not used by runc. Disable the installation, which will remove /usr/bin/tar: Permission denied errors.

Ref: https://github.com/opencontainers/runc/actions/runs/11019452323/job/30602046848#step:13:59

Sample run: https://github.com/akhilerm/runc/actions/runs/11026954586/job/30624383166#step:13:1

  • update bats-action to v2.1.1 that has support for cache key with multiple architectures

Fixes #4411

bats-core/bats-action installs a few support libraries by default which are not used by
runc. Disable the installation, which will remove /usr/bin/tar: Permission denied errors.

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm
Copy link
Contributor Author

akhilerm commented Sep 25, 2024

cc: @lifubang This will fix the warnings related to the tar that we see in the actions. Keeping the PR in draft since we have are still waiting on part 2, mentioned in #4411

Updated with fixes for the cache key issue.

@akhilerm akhilerm changed the title ci: remove installation of unused bats support libs ci: update bats-action to v2.1.0 Sep 25, 2024
@akhilerm
Copy link
Contributor Author

Saw an fd leak issue in one of the CI runs. Ref: https://github.com/opencontainers/runc/actions/runs/11029727694/job/30632792456?pr=4412#step:15:846. Thought it was already fixed in 1.23

@akhilerm akhilerm marked this pull request as ready for review September 25, 2024 09:11
@lifubang

This comment was marked as outdated.

@lifubang
Copy link
Member

bats-core/bats-action#18 (comment)

Please help to update to v2.1.1, thanks!

[email protected] supports:
- ubuntu 20.04
- cache key with multiple arch

Signed-off-by: Akhil Mohan <[email protected]>
@akhilerm akhilerm changed the title ci: update bats-action to v2.1.0 ci: update bats-action to v2.1.1 Sep 25, 2024
@akhilerm
Copy link
Contributor Author

Can we get this in, so that the CI can be unblocked ?

Copy link
Member

@lifubang lifubang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@lifubang
Copy link
Member

@opencontainers/runc-maintainers PTAL

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit 8e03054 into opencontainers:main Sep 26, 2024
42 checks passed
@akhilerm akhilerm deleted the remove-unused-bats-libs branch September 26, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] bats: command not found
3 participants