Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
initProcess
andsetnsProcess
have many same fields, and they are all in a big fileprocess_linux.go
, so let's do some refactor to this file:Introduce a common parent struct
containerProcess
, let bothinitProcess
andsetnsProcess
are inherited from it;MoveinitProcess
andsetnsProcess
definition and implementation out ofprocess_linux.go
, let them in their own seperate files:init_process_linux.go
andsetns_process_linux.go
, it will make more clear when reading and changing the code.EDIT: the second refactor could be refactored after the release-1.1 is EOL.
This refactor doesn't change any logic, and it's the first step of #4309 . After this refactor, both
initProcess
andsetnsProcess
can be treated ascontainerProcess
, we can only need to write some logic forcontainerProcess
, and then could be used for bothinitProcess
andsetnsProcess
.