return error if libcontainer desroy failed #4090
Conversation
|
/cc @kolyshkin @lifubang |
|
Please fix the lint error, you can see 48ff07c |
Burning1020
force-pushed
the
fix-cgroup-path
branch
2 times, most recently
from
fd712f2
to
79e0ea4
Compare
Done. |
| @@ -18,7 +18,7 @@ func killContainer(container *libcontainer.Container) error { | |||
| for i := 0; i < 100; i++ { | |||
| time.Sleep(100 * time.Millisecond) | |||
| if err := container.Signal(unix.Signal(0)); err != nil { | |||
| destroy(container) | |||
| _ = destroy(container) | |||
There was a problem hiding this comment.
Just keep others unchanged to make the minimum changes.
|
Another thing, please use |
Yes, I got it. The merge main commit is generated automatically by an "Update" button on Github pages. I should not click it the next time I saw it. |
Signed-off-by: Zhang Tianyang <[email protected]>
Burning1020
force-pushed
the
fix-cgroup-path
branch
from
82842b3
to
3c39079
Compare
|
@lifubang Can you help retry the ci? |
|
@lifubang @kolyshkin Does this pr need to be improved? I'm more concerned about the feasibility of the repair, not the time being merged. |
|
Ping @lifubang @kolyshkin |
|
Sorry, we are still in discussion. |
|
Yes, I think we should do this. I have written a similar commit in #4102 and put you (@Burning1020) as a co-author as you wrote it first; PTAL. |
|
Closing in favor of #4102 |
If there is an error in the destroy of libcontainer, it should be returned immediately and let the upper caller decided how to handle it.
Fix #4040