Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1] features: Fix ociMaxVersion #3989

Closed
wants to merge 1 commit into from
Closed

[1.1] features: Fix ociMaxVersion #3989

wants to merge 1 commit into from

Commits on Aug 21, 2023

  1. features: Fix ociMaxVersion 

    We are vendoring a runtime-spec version that breaks semver. Let's just
hardcode the ociMaxVersion, instead of using the version from the
bindings that reports "1.0.2-dev", that should be interpreted as
something bigger than "1.0.2".

That is not true according to semver, so let's just report "1.0.3-dev"
that is indeed bigger according to semver. We don't expect to change the
runtime-spec vendored version in the 1.1 release.

Signed-off-by: Rodrigo Campos <[email protected]>
    @rata
    rata committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    1affd25 View commit details
    Browse the repository at this point in the history